Fix port selection

betaflight · Oct 15, 2022 · 6cffcf6 · 6cffcf6
1 parent b5c2216
commit 6cffcf6
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/src/js/port_handler.js b/src/js/port_handler.js
@@ -18,6 +18,7 @@ const PortHandler = new function () {
     this.port_available = false;
     this.showAllSerialDevices = false;
     this.showVirtualMode = false;
+    this.usbCheckLoop = 0;
 };
 
 PortHandler.initialize = function () {
@@ -26,9 +27,6 @@ PortHandler.initialize = function () {
     this.selectList = document.querySelector(portPickerElementSelector);
     this.initialWidth = this.selectList.offsetWidth + 12;
 
-    this.showVirtualMode = ConfigStorage.get('showVirtualMode').showVirtualMode;
-    this.showAllSerialDevices = ConfigStorage.get('showAllSerialDevices').showAllSerialDevices;
-
     // fill dropdown with version numbers
     generateVirtualApiVersions();
 
@@ -120,8 +118,15 @@ PortHandler.initialize = function () {
         }
     }, MDNS_INTERVAL);
 
-    // start listening, check after TIMEOUT_CHECK ms
-    this.check();
+    this.reinitialize();    // just to prevent code redundancy
+};
+
+PortHandler.reinitialize = function () {
+    this.initialPorts = false;
+    clearTimeout(this.check_loop);
+    this.showVirtualMode = ConfigStorage.get('showVirtualMode').showVirtualMode;
+    this.showAllSerialDevices = ConfigStorage.get('showAllSerialDevices').showAllSerialDevices;
+    this.check();   // start listening, check after TIMEOUT_CHECK ms
 };
 
 PortHandler.check = function () {
@@ -135,7 +140,7 @@ PortHandler.check = function () {
         self.check_serial_devices();
     }
 
-    setTimeout(function () {
+    this.usbCheckLoop = setTimeout(function () {
         self.check();
     }, TIMEOUT_CHECK);
 };
@@ -196,7 +201,7 @@ PortHandler.check_usb_devices = function (callback) {
                     data: {isManual: true},
                 }));
 
-                self.portPickerElement.val('DFU').change();
+                self.portPickerElement.val('DFU').trigger('change');
                 self.setPortsInputWidth();
             }
             self.dfu_available = true;

diff --git a/src/js/tabs/options.js b/src/js/tabs/options.js
@@ -133,8 +133,10 @@ options.initShowAllSerialDevices = function() {
     const result = ConfigStorage.get('showAllSerialDevices');
     showAllSerialDevicesElement
         .prop('checked', !!result.showAllSerialDevices)
-        .on('change', () => ConfigStorage.set({ showAllSerialDevices: showAllSerialDevicesElement.is(':checked') }))
-        .trigger('change');
+        .on('change', () => {
+            ConfigStorage.set({ showAllSerialDevices: showAllSerialDevicesElement.is(':checked') });
+            PortHandler.reinitialize();
+        });
 };
 
 options.initShowVirtualMode = function() {
@@ -144,9 +146,8 @@ options.initShowVirtualMode = function() {
         .prop('checked', !!result.showVirtualMode)
         .on('change', () => {
             ConfigStorage.set({ showVirtualMode: showVirtualModeElement.is(':checked') });
-            PortHandler.initialPorts = false;
-        })
-        .trigger('change');
+            PortHandler.reinitialize();
+        });
 };
 
 options.initCordovaForceComputerUI = function () {