Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bind button for receivers that support it. #1873

Merged
merged 2 commits into from
Feb 8, 2020

Conversation

mikeller
Copy link
Member

@mikeller mikeller commented Feb 6, 2020

McGiverGim
McGiverGim previously approved these changes Feb 6, 2020
@asizon
Copy link
Member

asizon commented Feb 7, 2020

I tried this and it works perfect, it is a great improvement. Only 2 points, when I press the bind button graphically it does nothing, I don't know if it is working or not, could a Binding message be launched ... here?
bindinfo

In the other hand, I don't know if it's normal or not, but the Control Sticks button appears for 1 second:

controlsticksrefresh

@mikeller
Copy link
Member Author

mikeller commented Feb 7, 2020

@asizon:

I tried this and it works perfect, it is a great improvement. Only 2 points, when I press the bind button graphically it does nothing, I don't know if it is working or not, could a Binding message be launched ... here?

Yes, that is correct. The thing is that none of the protocols supporting bind through the firmware is currently set up to support feedback, and at least one of them (SRXL2) does not have any (publicly documented) facility to provide feedback, so for now giving feedback is probably going to be more confusing due to inconsistency than helpful.

In the other hand, I don't know if it's normal or not, but the 'Control Sticks' button appears for 1 second:

Yes, this is just the slowness of the V8 engine in processing the initialisation - we'd get the same if we disabled it initially in cases where it needs to be shown.

@McGiverGim
Copy link
Member

Yes, that is correct. The thing is that none of the protocols supporting bind through the firmware is currently set up to support feedback, and at least one of them (SRXL2) does not have any (publicly documented) facility to provide feedback, so for now giving feedback is probably going to be more confusing due to inconsistency than helpful.

Maybe we can simply add a message of Starting binding... or something similar in the log panel. I suppose that the problem is that we press the button and we don't receive any confirmation of that. In this way at least we know that the binding has been asked to the FC.

@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@mikeller
Copy link
Member Author

mikeller commented Feb 8, 2020

Ok, added a message to the log:

image

@mikeller mikeller merged commit 682472e into betaflight:master Feb 8, 2020
@mikeller mikeller deleted the add_bind_button branch February 8, 2020 07:47
@RipperDrone
Copy link
Contributor

This is a great addition to BF functionality and getting more and more less experienced users on board :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants