Update motor limit frame messages #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced references to 'Attenuation' and 'Limit' with 'Scaling'
|
Looks so good, with a real and true name. Thoughts @ctzsnooze ?? |
|
Really I do not know how it will affect the existing tutorials and knowledge of the feature name motor output limit. Also is true that this new Configurator adition is a opendoors to this feature for normal users, good moment to rename it. |
mikeller
reviewed
May 9, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
mikeller
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced message references to 'Attenuation' and 'Limit' with 'Scaling'
see #1901