Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to logging tab. More information and one correction #2943

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Jun 5, 2022

When using the loggin tab in betaflight, you have to no information before you do the selected logging. Added som leading text.

@blckmn
Copy link
Member

blckmn commented Jun 5, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

src/tabs/logging.html Outdated Show resolved Hide resolved
@haslinghuis haslinghuis added this to the 10.9.0 milestone Jun 5, 2022
Co-authored-by: haslinghuis <mark@numloq.nl>
@github-actions

This comment has been minimized.

src/tabs/logging.html Outdated Show resolved Hide resolved
Co-authored-by: haslinghuis <mark@numloq.nl>
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn blckmn merged commit 7c26e54 into betaflight:master Jun 28, 2022
@HThuren HThuren deleted the more_leading_text_to_logging_tab branch June 28, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants