RF: Moved Analytics to class #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
chmelevskij
reviewed
Jan 7, 2023
chmelevskij
reviewed
Jan 7, 2023
There was a problem hiding this comment.
I'm also getting following error on master
object_hash.js:1 Uncaught Error: Object argument required.
at u (object_hash.js:1:2030)
at t (object_hash.js:1:753)
at Function.sha1 (object_hash.js:1:1085)
at serial_backend.js:443:77
at Object.send_message (msp.js:323:17)
at processUid (serial_backend.js:440:9)
at serial_backend.js:435:9
at Object.send_message (msp.js:323:17)
at checkReportProblems (serial_backend.js:403:9)
at processBoardInfo (serial_backend.js:383:9)
at onOpenVirtual (serial_backend.js:325:5)
at Object.connectVirtual (serial.js:215:13)
at Object.connect (serial.js:33:18)
at HTMLAnchorElement.<anonymous> (serial_backend.js:75:32)
at HTMLAnchorElement.dispatch (jquery.min.js:2:43064)
at y.handle (jquery.min.js:2:41048)
u @ object_hash.js:1
t @ object_hash.js:1
sha1 @ object_hash.js:1
(anonymous) @ serial_backend.js:443
send_message @ msp.js:323
processUid @ serial_backend.js:440
(anonymous) @ serial_backend.js:435
send_message @ msp.js:323
checkReportProblems @ serial_backend.js:403
processBoardInfo @ serial_backend.js:383
onOpenVirtual @ serial_backend.js:325
connectVirtual @ serial.js:215
connect @ serial.js:33
(anonymous) @ serial_backend.js:75
dispatch @ jquery.min.js:2
y.handle @ jquery.min.js:2
At least in virtual mode. And assume this exists in this pr. Could we fix that while we are at it?
Is that on Receiver tab? I spotted this error, not related to analytics: |
Found it! |
|
AUTOMERGE: (FAIL)
|
This comment has been minimized.
This comment has been minimized.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
chmelevskij
approved these changes
Jan 7, 2023
haslinghuis
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulating the Analytics in a class.