Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom defaults #3361

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Remove custom defaults #3361

merged 1 commit into from
Mar 9, 2023

Conversation

haslinghuis
Copy link
Member

Do not process Custom Defaults for API 1.46

@haslinghuis haslinghuis added this to the 10.10.0 milestone Feb 27, 2023
@haslinghuis haslinghuis self-assigned this Feb 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Feb 27, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@nerdCopter
Copy link
Member

what is the expected behavior for firmware master @ MSP 1.45?
i.e. firmware master at 1.45 still allows apply custom defaults which breaks serial. (TMOTORF7) -- does firmware master need to be bumped at this time, or not yet?

@haslinghuis
Copy link
Member Author

This PR applies only to API >= 1.46 (firmware 4.5)

@nerdCopter
Copy link
Member

This PR applies only to API >= 1.46 (firmware 4.5)

i see it now; it took me a moment to follow what it was doing. i mistaken focused on src/js/serial_backend.js line 190, whereas the true purpose is line 414.

@haslinghuis haslinghuis merged commit 5b9c0ad into betaflight:master Mar 9, 2023
@haslinghuis haslinghuis deleted the remove-custom-defaults branch March 9, 2023 19:38
@haslinghuis haslinghuis mentioned this pull request Mar 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@blckmn blckmn blckmn approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: REFACTOR
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @nerdCopter @limonspb