Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup + led overlay expansion #3390

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Cleanup + led overlay expansion #3390

merged 4 commits into from
Apr 4, 2023

Conversation

ASDosjani
Copy link
Contributor

@ASDosjani ASDosjani commented Mar 21, 2023 •
edited
Loading

Betaflight changes: betaflight/betaflight#12554

Reverts #3391 because that doesn't solve the problem on my machine.
Please test if it looks the same for you.

Master:
image
My PR:
image

@ASDosjani ASDosjani mentioned this pull request Mar 21, 2023
Merged
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Mar 21, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 22, 2023
@ASDosjani ASDosjani marked this pull request as draft March 23, 2023 20:43
@github-actions

This comment has been minimized.

Sign in to view
@ASDosjani ASDosjani marked this pull request as ready for review March 26, 2023 14:08
@github-actions

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

nerdCopter
nerdCopter approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving -- looks symmetrical light and dark themed.

@haslinghuis haslinghuis merged commit e87ffaa into betaflight:master Apr 4, 2023
@ASDosjani ASDosjani deleted the led-bits branch June 11, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@ASDosjani ASDosjani

Labels
Cleanup Needs coordination with betaflight RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ASDosjani @blckmn @haslinghuis @nerdCopter