-
-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign of Firmware section at Setup tab #3770
Conversation
This comment has been minimized.
This comment has been minimized.
Looks really great, @HThuren ! Tested, works as proposed. Thank you! The orange buttons are very intuitive and helpful. Maybe the Perhaps the 'help' text could then go back into the ? icon where it previously was, as a pop-up when hovering over the |
@ctzsnooze thank you. |
IMHO, i prefer hover-over, not pop-out. sorry if i'm the only one. |
Hold fire on this PR as we are working on other methods to retrieve build options from firmware without the need for Build API queries as we need the options for LUA too. |
right, anyway changed back to help in cf_help tooltip, as wanted from @nerdCopter, since the yellow note require lot of space. |
Just saw it yesterday as it's not my contribution - so improving this PR now does not hurt as we only attend to improve back-end call functions. |
9216e38
to
ab52a1a
Compare
This comment has been minimized.
This comment has been minimized.
If we keep the 'hover' behaviour, we should use the standard A 'greyed out' button that doesn't work implies a 'normal' button that is disabled. It is bad UI design. The normal user might try to click it, just in case the colour loss was a mistake, but nothing happens, so that confirms their understanding that the button is disabled. They are likely to report this as a bug. We don't have any other 'greyed out' button elements that mean 'hover over me' on any other windows. A pop-out lets us copy the text, whereas a hover doesn't. Anyhow, I still prefer an orange button with a pop-out, but if you want to keep it a hover, then use PS There is another issue with the grey button hover, it is very slow to open, much slower than hovering over a |
@HThuren , just a note, i'm a relative new-comer to betaflight team. my opinions should be regarded as my own, not the team's. other team members should have priority and say as well. that said, i've been on computers since 1985 and i think i have good feel for things. edit: my concern with a pop-out was that such is a dialog that must be closed. this was my personal peeve. if there is a better way to do so, then i'm open. maybe it can auto-close if a user forgets it. 🤷♂️ |
@nerdCopter no worry, I also use my own jugdement :-) |
where are we at? |
Maybe part of 10.10 ? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
18873ce
to
d659ce7
Compare
This comment has been minimized.
This comment has been minimized.
NOW done, use the more simple and dynamic grid. Support dark theme. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Quality Gate passedIssues Measures |
Do you want to test this code? Here you have an automated build: |
* Redesign of Firmware section * layout change * popup work * change branch * more popup * also main * Final * Final.. * removed popup.js - not needed * with grid, missing center in frame * missing center in frame * Final * Grid without table * Fix quality gate issue * Simple and synamic gris, and dark theme supported * Update help * Update help * Update src/js/tabs/setup.js as suggested Co-authored-by: Mark Haslinghuis <mark@numloq.nl> --------- Co-authored-by: nerdCopter <56646290+nerdCopter@users.noreply.github.com> Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Changed according to request at discord
New design:
With local build and still logic if not online:
Press on Options give popup (possible to select text):
Old design: