Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash on connect #3858

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Mar 24, 2024

When using flash on connect:

  • the timer was not reset - resulting in a flash loop - asking for backup again.
  • we should be as quick as possible - skipping dialogs as the switch is mandatory for this behavior.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 24, 2024
@haslinghuis haslinghuis self-assigned this Mar 24, 2024
Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@ASDosjani
Copy link
Contributor

Works like a charm, thank you @haslinghuis 🥳

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • worked for me, but have to allow firmware to load first before toggling.

@haslinghuis
Copy link
Member Author

worked for me, but have to allow firmware to load first before toggling.

  • Never had to use this switch on my builds - so new terrain :)
  • When enabled and a new port is detected flash on connect will spam the flash button - as this would require a hex ready to flash (local or online).

Copy link
Member

@HThuren HThuren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worked for me, nice change

Copy link
Member

@asizon asizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haslinghuis haslinghuis merged commit c3bc74c into betaflight:master Mar 26, 2024
7 checks passed
@haslinghuis haslinghuis deleted the fix-backup-loop branch March 26, 2024 10:52
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@txmonstr
Copy link

With the new BF Configurator 10.10 I'm unable to connect to the FC via the Wifi of my ExpressLRS Reciver. With BF Cofigurator 10.9 there where no problems.

@haslinghuis
Copy link
Member Author

  • That has nothing to do with this fix :)
  • In options tab (when disconnected) enable the switch here

image

@txmonstr
Copy link

txmonstr commented Apr 29, 2024

Thats interesting. I turned on the switch and it still didn't work. It detects the board but then it closes the sereal port with this error message: "No configuration received within 10 seconds, communication failed". Do I maybe have to upgrade the FC to BF 4.5?

@ASDosjani
Copy link
Contributor

Thats interesting. I turned on the switch and it still didn't work. It detects the board but then it closes the sereal port with this error message: "No configuration received within 10 seconds, communication failed". Do I maybe have to upgrade the FC to BF 4.5?

That's probably because of the very poor ELRS wifi antenna... Let's move this conversation to Discord, it's not related to this bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

6 participants