Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rotation of the sponsor logos. #3888

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Apr 11, 2024

No description provided.

@blckmn blckmn self-assigned this Apr 11, 2024
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for origin-betaflight-configurator ready!

Name Link
🔨 Latest commit e26bd04
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-configurator/deploys/661747c31ecef20008b2a91c
😎 Deploy Preview https://deploy-preview-3888--origin-betaflight-configurator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@sugaarK sugaarK requested a review from KarateBrot April 11, 2024 03:09
@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 11, 2024
@sugaarK sugaarK merged commit b7d861c into betaflight:master Apr 11, 2024
11 checks passed
@blckmn blckmn deleted the rotating_sponsors branch April 11, 2024 10:25
@McGiverGim
Copy link
Member

I don't know if it's intended. At least under PWA, the refresh of the logos is too rude. Sometimes it seems the page is reloading because the logos dissappear and then they appear in less than a second. This does not happen always, maybe depending if they are cached or not.
Maybe there is a way to make the transition smooth? I know jquery has methods to make it, maybe using fadeOut() and fadeIn(), but there are more: https://api.jquery.com/fadeOut/

@McGiverGim
Copy link
Member

Another suggestion, maybe a link near the logos, with "all our sponsors" that goes to the wiki to a page with all of them will make easier to show them to the users.

@blckmn
Copy link
Member Author

blckmn commented Apr 11, 2024

These are great ideas. I'll add some more PRs.

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

4 participants