Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Board documentation for new format docs #398

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

VitroidFPV
Copy link
Member

As new target submissions will be strongly encouraged to provide documentations and/or board samples for developer verification + documentation, there should be a clear distinction between the old and the new pages.
image

The first entry takes from the provided example, more will be added as manufacturers/developers contribute docs for newly released (and maybe existing) boards.

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for origin-betaflight-com ready!

Name Link
🔨 Latest commit 5ada938
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-com/deploys/66042244fdba190008cbdfc8
😎 Deploy Preview https://deploy-preview-398--origin-betaflight-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis
Copy link
Member

@VitroidFPV please note the board needs to be uppercase as detected by firmware. Also some boards like KAKUTE were recently updated - but perhaps not using new standard - if the intention is to start fresh.

@VitroidFPV
Copy link
Member Author

Writing some instructions on how to submit the documentation as well, will push up in a little bit

@VitroidFPV
Copy link
Member Author

I will rename it accordingly. The Current category serves to only show the documentation files that follow the new standard. I will try to set some time apart to write up the boards I have on hand

@haslinghuis
Copy link
Member

Thank you - much appreciated - please check attached configurator PR to keep in sync.

@haslinghuis
Copy link
Member

There is no new preview - so can not check without building local

image

Is the BOARD being duplicated in the path?

@VitroidFPV
Copy link
Member Author

VitroidFPV commented Mar 27, 2024

Is the BOARD being duplicated in the path?

The document file itself is in a directory of the same name. That basically just allows a directory containing multiple files to show up as a single document in the sidebar - so that we can have a folder with all the images at the same directory level as the board documentation file without introducing a lot of clutter

@VitroidFPV
Copy link
Member Author

Please review the documentation guide and recommend any potential changes. Other than that I think it's good to go 😅

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,105 @@
# How to Create Board Documentation

The newly created board documentation format is made to take full advantage of the features available with the documentation platform in use - docusaurusVersion. It is extended with features not present in the default markdown format, and may be more complex to work with.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docusaurusVersion ?

Also might add a link to markdown format

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autocomplete showing up where it really shouldn't 😅 I'll fix it and add a link to some markdown resources

@nerdCopter
Copy link
Member

What is the difference between Archive and Legacy? i.e. should they be combined, or no?

@VitroidFPV
Copy link
Member Author

What is the difference between Archive and Legacy? i.e. should they be combined, or no?

Archive has board docs for boards that should still be supported, but don't follow the updated format. Legacy is for old F1/F3 boards. I thought about deleting those entirely, but this PR is just for organization

nerdCopter
nerdCopter previously approved these changes Mar 27, 2024
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nerdCopter
Copy link
Member

this repo properly dismisses approvals upon new commits. other repos do not, but such is convenient.

@haslinghuis haslinghuis merged commit f71f379 into betaflight:master Mar 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants