Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextest compatibility #602

Merged
merged 10 commits into from
Dec 6, 2022
Merged

Conversation

sunshowers
Copy link
Contributor

This commit stack makes criterion compatible with nextest using the rules listed here. Each commit is independently reviewable.

Note that none of these changes do anything special for nextest -- they just make criterion implement more of the libtest command-line interface, just enough to make nextest happy.

Addresses #562 -- once this commit stack lands and a new version of criterion goes out, I'd be happy to advertise compatibility on the nextest site.

@sunshowers
Copy link
Contributor Author

(Let me know if I should target 0.4 or master for this)

@aldanor
Copy link

aldanor commented Sep 4, 2022

This is awesome, would be great to have this reviewed and land. Wonder if there is anything blocking?

@bheisler
Copy link
Owner

No, the only blocker is that I have limited time and energy to spend on open-source work lately. My apologies for the delay, I'll try to get to it at some point.

This makes a plain `--list` work. Note that this shouldn't result in any
compatibility issues since --list is mutually exclusive with --test.
Warnings shouldn't go to stdout.
This is required for cargo-nextest.
Since criterion doesn't have a notion of ignored tests, this skips over
all tests.
Required by cargo-nextest.
GitHub CI supports ANSI color codes, so this makes the output look a lot
prettier.
@lemmih lemmih merged commit 28a42f1 into bheisler:master Dec 6, 2022
@sunshowers
Copy link
Contributor Author

@lemmih do you think you'd be able to get a version out with this soon? Had another request come in today.

@lemmih
Copy link
Collaborator

lemmih commented Jan 12, 2023

Releases are managed by @bheisler.

@sunshowers sunshowers deleted the nextest-compat branch May 10, 2023 17:19
@sunshowers
Copy link
Contributor Author

Hi @bheisler, do you think you'd be able to make a release soon? Thank you so much for maintaining criterion!

@lemmih
Copy link
Collaborator

lemmih commented May 10, 2023

Hi @bheisler, do you think you'd be able to make a release soon? Thank you so much for maintaining criterion!

Brook gave me permission to release a new version. Think you could help me update the CHANGELOG.md? We probably also want to review #679 before cutting a release.

@sunshowers
Copy link
Contributor Author

Thanks @lemmih. Happy to spend some time on this tomorrow. What would be a good way to coordinate our efforts?

@lemmih
Copy link
Collaborator

lemmih commented May 10, 2023

Thanks @lemmih. Happy to spend some time on this tomorrow. What would be a good way to coordinate our efforts?

If you begin updating the changelog, put the changes in a draft PR.

@nbarrios1337
Copy link
Contributor

work-in-progress updates for the changelog -> #680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants