-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanups, code to function, key repeat, ... #3
base: main
Are you sure you want to change the base?
Conversation
Oh, do you want the binary file to be updated with every change? |
Yes the binary should be the result of the current code, so people can try it without installing anything. I have a couple other projects where this makes more sense (weird SDKs and such, specific compiler versions, stuff like that), and it became a bit of a habit. |
I will rebase the commits and add the binary file then. |
As rebasing with binary files is a pain... Can you have your review first, please? |
yes sure, you can leave the binary to me actually |
It seems I remember quite little about this code.. |
Thanks! Well, currently it works for me... So no need for a rush. Perhaps I should take a break here for this to settle before I continue looking at the two-byte storage in eeprom and better support for all key codes. By the way... Some of the (later) changes may look over-engineered at first glace, but I made them in preparation of storing more information for the keys, like modifiers, sequences/macros, ... |
... except for knob
Using separate press and release (instead of the squashed type) makes the key repeat work. I did rework all the code... |
No description provided.