Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups, code to function, key repeat, ... #3

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

eworm-de
Copy link

No description provided.

@eworm-de
Copy link
Author

eworm-de commented May 24, 2023

Oh, do you want the binary file to be updated with every change?
Usually I would not put that in a repository at all...

@biemster
Copy link
Owner

Yes the binary should be the result of the current code, so people can try it without installing anything. I have a couple other projects where this makes more sense (weird SDKs and such, specific compiler versions, stuff like that), and it became a bit of a habit.
Thanks for this code! I'll have a look when time permits.

@eworm-de
Copy link
Author

I will rebase the commits and add the binary file then.

@eworm-de
Copy link
Author

As rebasing with binary files is a pain... Can you have your review first, please?
I will update the files if the changes to source are fine.

@biemster
Copy link
Owner

yes sure, you can leave the binary to me actually

README.md Outdated Show resolved Hide resolved
3keys_1knob.c Outdated Show resolved Hide resolved
@biemster
Copy link
Owner

It seems I remember quite little about this code..
It might take me a bit to review this, but it looks great at first glance!

@eworm-de
Copy link
Author

Thanks!

Well, currently it works for me... So no need for a rush. Perhaps I should take a break here for this to settle before I continue looking at the two-byte storage in eeprom and better support for all key codes.
Let's hope I will remember the code then. 😝

By the way... Some of the (later) changes may look over-engineered at first glace, but I made them in preparation of storing more information for the keys, like modifiers, sequences/macros, ...

@eworm-de
Copy link
Author

Using separate press and release (instead of the squashed type) makes the key repeat work. I did rework all the code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants