Skip to content

Commit

Permalink
BCTHEME-214 Wishlist first option has no bottom outline when in focus (
Browse files Browse the repository at this point in the history
…#1825)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>
  • Loading branch information
yurytut1993 and BC-tymurbiedukhin authored Oct 21, 2020
1 parent a356f42 commit 10898ad
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Wishlist first option has no bottom outline when in focus. [#1825](https://github.com/bigcommerce/cornerstone/pull/1825)
- Carousel hidden when one or more of its images not found. [#1816](https://github.com/bigcommerce/cornerstone/pull/1816)
- Rating and Other filter sections should be accessible by keyboard. [#1838](https://github.com/bigcommerce/cornerstone/pull/1838)
- Fixed header logo focus border for voiceover and browser. [#1831](https://github.com/bigcommerce/cornerstone/pull/1831)
Expand Down
12 changes: 12 additions & 0 deletions assets/scss/components/foundation/dropdown/_dropdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
}

.dropdown-menu {
z-index: $zIndex-lowest;

&.is-loading .loadingOverlay {
background: none;
padding: (spacing("double") + spacing("single")) 0;
Expand All @@ -19,6 +21,12 @@
&.is-open {
display: block;
}

.button {
&:focus {
z-index: $zIndex-lowest;
}
}
}

.dropdown-menu-item {
Expand Down Expand Up @@ -63,6 +71,10 @@
float: right;
margin-left: 10px;
}

&:focus {
z-index: $zIndex-lower;
}
}

#wishlist-dropdown.is-open {
Expand Down

0 comments on commit 10898ad

Please sign in to comment.