Skip to content

Commit

Permalink
fix(storefront): BCTHEME-217 Product link has incorrect voice over fo…
Browse files Browse the repository at this point in the history
…cus on Cart Page
  • Loading branch information
yurytut1993 committed Oct 5, 2020
1 parent 797b3da commit 32a6e64
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Product link has incorrect voice over focus on Cart Page. [#1830](https://github.com/bigcommerce/cornerstone/pull/1830)
- Create unified focus styling in Cornerstone. [#1812](https://github.com/bigcommerce/cornerstone/pull/1812)
- Review link in quick modal focused twice. [#1797](https://github.com/bigcommerce/cornerstone/pull/1797)
- Fixed product image doesn't change on click when viewing a product with multiple images in IE11 [#1748](https://github.com/bigcommerce/cornerstone/pull/1748)
Expand Down
5 changes: 5 additions & 0 deletions assets/scss/components/stencil/cart/_cart.scss
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,11 @@ $cart-item-label-offset: $cart-thumbnail-maxWidth + $cart-item-sp
.cart-item-name {
font-size: fontSize("smaller");
margin: 0;
display: inline-block;

&__label {
display: inline-block;
}

+ .definitionList {
margin-top: spacing("quarter");
Expand Down
4 changes: 3 additions & 1 deletion templates/components/cart/content.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@
{{#if brand.name}}
<p class="cart-item-brand">{{brand.name}}</p>
{{/if}}
<h2 class="cart-item-name"><a href="{{url}}">{{name}}</a></h2>
<h2 class="cart-item-name">
<a class="cart-item-name__label" href="{{url}}">{{name}}</a>
</h2>
{{#if release_date}}
<p>({{release_date}})</p>
{{/if}}
Expand Down

0 comments on commit 32a6e64

Please sign in to comment.