Skip to content

Commit

Permalink
Fix latest node-sass issues with Citadel upgrade and conditional impo…
Browse files Browse the repository at this point in the history
…rt swap with mixin
  • Loading branch information
Michael Schock committed Apr 25, 2017
1 parent 7bb7ef5 commit 562bdf6
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 15 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fix latest node-sass issues with Citadel upgrade and conditional import swap with mixin [#999](https://github.com/bigcommerce/cornerstone/pull/999)
- Repopulate review form fields after error [#996](https://github.com/bigcommerce/cornerstone/pull/996)
- Fix product quick view 'Write a Review' link [#995](https://github.com/bigcommerce/cornerstone/pull/995)
- Update bigcommerce.com footer link [#990](https://github.com/bigcommerce/cornerstone/pull/990)
Expand Down
28 changes: 15 additions & 13 deletions assets/scss/fonts/_clear-sans.scss
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
@font-face {
font-family: "Clear Sans";
font-style: normal;
font-weight: 400;
src: url("../fonts/clearsans-regular-webfont.woff2") format("woff2"),
url("../fonts/clearsans-regular-webfont.woff") format("woff");
}
@mixin clear-sans {
@font-face {
font-family: "Clear Sans";
font-style: normal;
font-weight: 400;
src: url("../fonts/clearsans-regular-webfont.woff2") format("woff2"),
url("../fonts/clearsans-regular-webfont.woff") format("woff");
}

@font-face {
font-family: "Clear Sans";
font-style: normal;
font-weight: 700;
src: url("../fonts/clearsans-bold-webfont.woff2") format("woff2"),
url("../fonts/clearsans-bold-webfont.woff") format("woff");
@font-face {
font-family: "Clear Sans";
font-style: normal;
font-weight: 700;
src: url("../fonts/clearsans-bold-webfont.woff2") format("woff2"),
url("../fonts/clearsans-bold-webfont.woff") format("woff");
}
}
4 changes: 3 additions & 1 deletion assets/scss/fonts/_fonts.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
@import "clear-sans";

$fonts: $fontFamily-sans $fontFamily-serif $fontFamily-mono $fontFamily-headings $fontFamily-hero;

@if contains($fonts, "'Clear Sans', sans-serif") {
@import "clear-sans";
@include clear-sans;
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"author": "BigCommerce",
"license": "MIT",
"devDependencies": {
"@bigcommerce/citadel": "^2.11.5",
"@bigcommerce/citadel": "^2.15.1",
"@bigcommerce/stencil-utils": "1.0.5",
"async": "^1.5.2",
"babel-core": "6.7.4",
Expand Down

0 comments on commit 562bdf6

Please sign in to comment.