Skip to content

Commit

Permalink
Merge pull request #1438 from Ubersmake/1397
Browse files Browse the repository at this point in the history
Updated Default Image path in theme config.
  • Loading branch information
Ubersmake authored Feb 1, 2019
2 parents 43b04e8 + 1e96965 commit 5cc0b7c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Ensure SKU and UPC display correctly for Variants on PDP. [#1431](https://github.com/bigcommerce/cornerstone/pull/1431)
- Corrected IDs in date.html form fields. [#1433](https://github.com/bigcommerce/cornerstone/pull/1433)
- Cleanup and XSS fix on Cart page. [#1434](https://github.com/bigcommerce/cornerstone/pull/1434)
- Fix for product without image on Compare page. [#1438](https://github.com/bigcommerce/cornerstone/pull/1438)

- Resolve settings scope passed to components. [#1435](https://github.com/bigcommerce/cornerstone/pull/1435)

Expand Down
6 changes: 3 additions & 3 deletions config.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@
"thumb_size": "100x100",
"zoom_size": "1280x1280",
"blog_size": "190x250",
"default_image_brand": "/assets/img/BrandDefault.gif",
"default_image_product": "/assets/img/ProductDefault.gif",
"default_image_gift_certificate": "/assets/img/GiftCertificate.png",
"default_image_brand": "img/BrandDefault.gif",
"default_image_product": "img/ProductDefault.gif",
"default_image_gift_certificate": "img/GiftCertificate.png",
"body-font": "Google_Karla_400",
"headings-font": "Google_Montserrat_400",
"fontSize-root": 14,
Expand Down
2 changes: 1 addition & 1 deletion templates/pages/compare.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ <h1 class="page-heading">{{lang 'compare.header' products=comparisons.length}}</
<article class="card">
<figure class="card-figure">
<div class="card-img-container">
<img class="card-image lazyload" data-sizes="auto" src="{{cdn 'img/loading.svg'}}" data-src="{{getImage image 'product_size' (cdn theme_settings.default_image_product)}}" alt="{{image.alt}}" title="{{image.alt}}">
<img class="card-image lazyload" data-sizes="auto" src="{{cdn 'img/loading.svg'}}" data-src="{{getImage image 'product_size' (cdn ../theme_settings.default_image_product)}}" alt="{{image.alt}}" title="{{image.alt}}">
</div>
<a class="compareTable-removeProduct" data-comparison-remove href="{{#if remove_url}}{{remove_url}}{{else}}#{{/if}}">
<svg class="icon">
Expand Down

0 comments on commit 5cc0b7c

Please sign in to comment.