Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STENCIL-3508 #1017

Merged
merged 1 commit into from
Jun 7, 2017
Merged

STENCIL-3508 #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
# Changelog

## Draft
- Swaps `writeReview` for `write_review` to fix email link issue [#1017](https://github.com/bigcommerce/cornerstone/pull/1017)

## 1.8.1 (2017-05-05)
- Bug fix for category sidebar [#1006](https://github.com/bigcommerce/cornerstone/pull/1006)

## 1.8.0 (2017-05-04)
- Add storefront admin bar to replace store not launched preview panel [#997](https://github.com/bigcommerce/cornerstone/pull/997)
Expand Down
4 changes: 2 additions & 2 deletions assets/js/theme/product.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default class Product extends PageManager {
before(next) {
// Listen for foundation modal close events to sanitize URL after review.
$(document).on('close.fndtn.reveal', () => {
if (this.url.indexOf('#writeReview') !== -1 && typeof window.history.replaceState === 'function') {
if (this.url.indexOf('#write_review') !== -1 && typeof window.history.replaceState === 'function') {
window.history.replaceState(null, document.title, window.location.pathname);
}
});
Expand Down Expand Up @@ -63,7 +63,7 @@ export default class Product extends PageManager {
}

productReviewHandler() {
if (this.url.indexOf('#writeReview') !== -1) {
if (this.url.indexOf('#write_review') !== -1) {
this.$reviewLink.click();
}
}
Expand Down
2 changes: 1 addition & 1 deletion templates/components/products/product-view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ <h2 class="productView-brand"{{#if schema}} itemprop="brand" itemscope itemtype=
{{/if}}
{{#if settings.show_product_reviews}}
<span class="productView-reviewLink">
<a href="{{product.url}}{{#if is_ajax}}#writeReview{{/if}}"
<a href="{{product.url}}{{#if is_ajax}}#write_review{{/if}}"
{{#unless is_ajax }}data-reveal-id="modal-review-form"{{/unless}}>
{{lang 'products.reviews.new'}}
</a>
Expand Down