Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STENCIL-3380: Adds auto height to alternative nav menu and submenus. #1056

Merged
merged 1 commit into from
Aug 14, 2017
Merged

STENCIL-3380: Adds auto height to alternative nav menu and submenus. #1056

merged 1 commit into from
Aug 14, 2017

Conversation

cristycarpenter
Copy link
Contributor

What?

This change ensures the alternative navigation menu and its submenus always have the proper background length no matter how many categories a merchant has.

Tickets / Documentation

https://jira.bigcommerce.com/browse/STENCIL-3380

Screenshots (if appropriate)

Before/After for Main Menu:
https://www.screencast.com/t/Dueilwqbp

Before/After for Submenus:
https://www.screencast.com/t/qOgJbQnM

@@ -320,7 +321,7 @@
@include breakpoint("medium") {
border-left: 1px solid stencilColor("navPages-subMenu-separatorColor");
display: inherit;
height: $navPage-subMenu-horizontal-height;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this variable being used anywhere else ? Or can we remove the definition as well completely ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see that it was being used anywhere else but was hesitant to remove it myself. If you think it's best, I can go ahead with it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing this variable please change the value of the variable to auto, in assets/scss/settings/stencil/navPages/_settings.scss

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and yes, it is only used here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. Thanks, Mario.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the changes made. Need to squash my commits still. Will do so in the morning :)

Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍 . This does need a rebase.

@junedkazi junedkazi merged commit cc83ee3 into bigcommerce:master Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants