STENCIL-3536 bulk discount rates #1058
Conversation
mcampa
force-pushed
the
STENCIL-3536-bulk_rates
branch
from
189405c
to
268c252
Compare
| @@ -82,5 +82,40 @@ <h4 class="card-title"> | |||
| {{> components/common/login-for-pricing}} | |||
| {{/or}} | |||
| </div> | |||
| {{#if bulk_discount_rates.length}} | |||
There was a problem hiding this comment.
I think it would be nice if we moved this into a component.
| {{#each bulk_discount_rates}} | ||
| <li> | ||
| {{lang 'products.bulk_pricing.range' min=min max=max}} | ||
| {{#if type '===' 'percent'}} |
There was a problem hiding this comment.
from where are we getting this type ?
There was a problem hiding this comment.
from {{#each bulk_discount_rates}}
each creates a new context for each block
| @@ -82,5 +82,7 @@ <h4 class="card-title"> | |||
| {{> components/common/login-for-pricing}} | |||
| {{/or}} | |||
| </div> | |||
| {{> components/common/login-for-pricing}} | |||
There was a problem hiding this comment.
We already display the login for pricing above. Why do we need it here ?
There was a problem hiding this comment.
My mistake, this shouldn't be here
| @@ -82,5 +82,7 @@ <h4 class="card-title"> | |||
| {{> components/common/login-for-pricing}} | |||
| {{/or}} | |||
| </div> | |||
| {{> components/common/login-for-pricing}} | |||
| {{> components/products/bulk-discount-rates}} | |||
There was a problem hiding this comment.
Do you think this needs to be wrapped in a setting ? 🍹
There was a problem hiding this comment.
Is already wrapped, in the component file
config.json
Outdated
| @@ -275,6 +275,7 @@ | |||
| ], | |||
| "resources": { | |||
| "cart": true, | |||
| "bulk_discount_rates": true, | |||
There was a problem hiding this comment.
Does this mean bulk discounts will be loaded on all pages ?
There was a problem hiding this comment.
Yes. All pages that have product context. But I'm going to change it to default to false
mcampa
force-pushed
the
STENCIL-3536-bulk_rates
branch
from
ee8bf9b
to
eb4b389
Compare
|
Right now not working on 2.0.0 |
Add bulk discount rates to product cards
https://jira.bigcommerce.com/browse/STENCIL-3695
@bigcommerce/stencil-team