STRF-4455: Fixing easyzoom on mobile viewports in landscape from preventing scro… #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
@jfasanobc LGTM - can you please rebase into one commit |
|
@jfasanobc - actually, i can squash and merge from here - i'll do that! |
adamdyche
pushed a commit
to adamdyche/cornerstone
that referenced
this pull request
Feb 6, 2018
…enting scro… (bigcommerce#1164) * Fixing easyzoom on mobile viewports in landscape from preventing scrolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When mobile devices are in landscape (Android, iPad, iPhone) the image zoom triggers while the touch is detected on the image and covers almost all of the screen that is needed to scroll. This prevents the user from going back up or scrolling further down.
Tickets / Documentation
Screenshots (if appropriate)
Before:
@after:
@mjschock