Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog): CATALOG-3085 default selection in quickview #1197

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

ziad-abdo
Copy link
Contributor

What?

refrain from updating the price shown on
quickview by default when the modal is rendered unless theres an
actual default selection to be made.

Tickets / Documentation

Screenshots (if appropriate)

Before: The quickview page would instantly make a request for stock/price based on selection even if the product doesnt have a default selection, which would result in getting the base price.
screen shot 2018-03-29 at 4 38 01 pm

After: The quickview page still makes the default request so that it can mark things as OOS when necessary, but it doesnt try to change the price in the view if its not applicable.
screen shot 2018-03-29 at 4 36 42 pm

@bigbot
Copy link

bigbot commented Mar 29, 2018

Autotagging @bigcommerce/storefront-team @davidchin

Copy link

@megdesko megdesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but I defer to @bigcommerce/storefront-team

@bc-jz
Copy link
Contributor

bc-jz commented Apr 4, 2018

💚 - this update looks to be working as expected

    quickview by default when the modal is rendered unless theres an
    actual default selection to be made.
@ziad-abdo ziad-abdo merged commit 827c126 into bigcommerce:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants