Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrow placement on currency selector dropdown #1267

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Fix arrow placement on currency selector dropdown #1267

merged 1 commit into from
Jun 15, 2018

Conversation

sacr3dc0w
Copy link
Contributor

@sacr3dc0w sacr3dc0w commented Jun 11, 2018

What

The arrow on the currency selector dropdown is left aligned when it needs to be right aligned.

Documentation

#1254

Images

Before
01 before
After
02 after

@bigbot
Copy link

bigbot commented Jun 11, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@junedkazi
Copy link
Contributor

@sacr3dc0w can you also share mobile views screens to make sure it works fine across all sizes.

@junedkazi
Copy link
Contributor

time to rebase this PR

@sacr3dc0w
Copy link
Contributor Author

@junedkazi The arrow disappears on small viewports (<800px). I couldn't locate where this rule occurs, though.

currency dropdown closed
1 closed
currency dropdown open
2 open

@junedkazi junedkazi merged commit 413dd3b into bigcommerce:master Jun 15, 2018
@sacr3dc0w sacr3dc0w deleted the currency-dropdown branch June 15, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants