Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable arrows on the homepage carousel #1293

Merged
1 commit merged into from
Oct 9, 2018
Merged

Add option to disable arrows on the homepage carousel #1293

1 commit merged into from
Oct 9, 2018

Conversation

sacr3dc0w
Copy link
Contributor

What?

Currently if you want to hide/disable the arrows on the homepage carousel, you'll need to use either CSS or add JavaScript to the bundle. This PR adds an option to the theme editor.

Tickets / Documentation

Screenshots

True (Default)
01 true default
False
02 false
Theme Editor
03 theme editor

@bigbot
Copy link

bigbot commented Jun 28, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@junedkazi
Copy link
Contributor

This PR needs a rebase.

@ghost
Copy link

ghost commented Oct 8, 2018

@sacr3dc0w LGTM, Just one comment Please change capitalization to "Show carousel arrows". We can merge that after rebase

@@ -907,6 +907,12 @@
"force_reload": true,
"id": "homepage_show_carousel"
},
{
"type": "checkbox",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @BC-EChristensen

schema.json Outdated
@@ -907,6 +907,12 @@
"force_reload": true,
"id": "homepage_show_carousel"
},
{
"type": "checkbox",
"label": "Show Carousel Arrows",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have the capitalization changed to be Show carousel arrows, but looks good other than that.

@ghost ghost closed this Oct 9, 2018
@ghost ghost reopened this Oct 9, 2018
@ghost ghost closed this Oct 9, 2018
@ghost ghost reopened this Oct 9, 2018
@ghost ghost merged commit f21dfff into bigcommerce:master Oct 9, 2018
@sacr3dc0w sacr3dc0w deleted the no-home-arrows branch October 9, 2018 17:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants