Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo New Products left align from 2.3.0. #1328

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Undo New Products left align from 2.3.0. #1328

merged 1 commit into from
Aug 13, 2018

Conversation

Ubersmake
Copy link
Contributor

@Ubersmake Ubersmake commented Aug 13, 2018

What?

Reverting #1321 until we can find a better solution for all cases. New products were left-aligned, but once there were four products the fourth product would be pushed into a new row.

The caveat here is that merchants who are displaying less than four new products on Cornerstone should probably keep the changes to _productCarousel.scss in ca0f3cd.

Tickets / Documentation

Screenshots

Before (2.3.1)
3 Products

before3

5 Products

before5

After (or 2.2.1)
3 Products. Note the justification.

after3

5 Products. Note the carousel.

after5

@bigbot
Copy link

bigbot commented Aug 13, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@Ubersmake Ubersmake requested review from a user and junedkazi August 13, 2018 21:48
@Ubersmake Ubersmake merged commit 3222c48 into bigcommerce:master Aug 13, 2018
@Ubersmake Ubersmake deleted the STRF-5291 branch August 13, 2018 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants