Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-5474 Improve performance of first carousel slide #1356

Merged
merged 1 commit into from
Sep 24, 2018
Merged

STRF-5474 Improve performance of first carousel slide #1356

merged 1 commit into from
Sep 24, 2018

Conversation

bookernath
Copy link
Contributor

@bookernath bookernath commented Sep 23, 2018

What?

-Don't lazyload first slide (avoids FOUC and weird behavior)
-Tiny refactor replacing multiple #if statements with #and
-rel=preload tag for first carousel slide (if present) to improve download time will do this later

Tickets / Documentation

Add links to any relevant tickets and documentation.

ping @junedkazi @mattolson @bc-zoharmuzafi

@bigbot
Copy link

bigbot commented Sep 23, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@@ -3,6 +3,11 @@
<head>
<title>{{ head.title }}</title>
{{{ resourceHints }}}

{{#if carousel.slides.[0].image}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this with a store with no carousel? Interested to know what the context looks like in that case and whether this conditional still works.

-rel=preload tag for first carousel slide (if present)
-don't lazyload first slide
@Ubersmake Ubersmake merged commit b9703e0 into bigcommerce:master Sep 24, 2018
@bookernath bookernath deleted the STRF-5474 branch September 25, 2018 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants