Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYMENTS-3071 Add the schema and config options for paypal smart button configuration #1359

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

lord2800
Copy link
Contributor

What?

This adds support for customizing the look and feel of the Paypal and Braintree checkout buttons on the cart (and other) pages. Some of the options are mutually exclusive, but there's currently no way to represent that in the schema--those mutually exclusive options will simply fail to render buttons on the page, so it falls on the merchant to discover that their payment buttons don't render and select options that do. This new section is hidden when the merchant does not have Paypal or Braintree enabled as a payment gateway.

Tickets / Documentation

Screenshots (if appropriate)

screen shot 2018-09-24 at 11 35 39 am

Copy link
Contributor

@Ubersmake Ubersmake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

@mattolson
Copy link
Contributor

cc @bigcommerce/merc-team Cornerstone schema changes

@Ubersmake
Copy link
Contributor

@lord2800 Could you rebase and add a CHANGELOG entry?

@lord2800
Copy link
Contributor Author

Done.

@ghost
Copy link

ghost commented Sep 24, 2018

@BC-EChristensen @kchu93 let's please review this settings w SD

@lord2800
Copy link
Contributor Author

I'm happy to explain how to get this to show up if needed.

@Ubersmake Ubersmake merged commit 77bb7b5 into bigcommerce:master Sep 24, 2018
@lord2800 lord2800 deleted the PAYMENTS-3071 branch September 24, 2018 23:19
@tvlgiao
Copy link

tvlgiao commented Oct 11, 2018

Hi @lord2800 I added this PR to our theme but it doesn't seem to work. Please check this screenshot: http://prntscr.com/l4ot21
Do you know why? Thank you!

@lord2800
Copy link
Contributor Author

The options aren't yet active. I'm still working on that part.

@lonestartemplates
Copy link

are the options working yet?

@lord2800
Copy link
Contributor Author

lord2800 commented Feb 4, 2019

They are for Braintree, but not yet for PayPal.

@lonestartemplates
Copy link

Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants