MERC-4196: Fixes issue with Slick slider for mobile safari #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
pedelman
commented
Oct 12, 2018
christensenep
approved these changes
Oct 15, 2018
|
@Ubersmake updated to include the change log ♻️ |
Ubersmake
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Loading Cornerstone inside an iframe on mobile safari will cause your web browser to become unresponsive.
There look to be multiple issues at play, the first being some css changes as suggested in the linked ticket. I have also tracked down the setting which is causing another issue, it looks like something in this block of code is breaking on mobile safari in an iframe.
You can reproduce this issue in isolation using the following codepen example.
Using the iPad emulator in xcode, open safari and navigate to the following page.
Compare results against desktop web browser.
Tickets / Documentation
There is an open issue on Slick, the open source slider we are using.
Screenshots
Before:
After:
