STRF-4613 Defer loading addthis widget js script #1395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
force-pushed
the
defer-add-this
branch
from
04f6283
to
cb61607
Compare
mattolson
reviewed
Dec 5, 2018
| @@ -61,7 +61,7 @@ | |||
| {{/each}} | |||
| </ul> | |||
| <script type="text/javascript" | |||
| src="//s7.addthis.com/js/300/addthis_widget.js#pubid=ra-4e94ed470ee51e32"></script> | |||
| src="//s7.addthis.com/js/300/addthis_widget.js#pubid=ra-4e94ed470ee51e32" defer></script> | |||
There was a problem hiding this comment.
I don't think it's this simple, because the script just below depends on this script loading first.
|
Closing in favor of #1406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Defer loading addthis widget js script
Tickets / Documentation
https://jira.bigcommerce.com/browse/STRF-4613
Screenshots (if appropriate)
@bigcommerce/storefront-team