Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ESLint "func-names" warnings #1420

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Fix for ESLint "func-names" warnings #1420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Draft

- Fix for ESLint "func-names" warnings. [#1420](https://github.com/bigcommerce/cornerstone/pull/1420)
- Major performance improvements. Reduce Javascript bundle size from 376kb to 286kb. [#1390](https://github.com/bigcommerce/cornerstone/pull/1390)
- Fixed breadcrumbs for product and category pages [#1403](https://github.com/bigcommerce/cornerstone/pull/1403)
- Send GA tracking event whenever the last product is removed from the CART[#1409](https://github.com/bigcommerce/cornerstone/pull/1409)
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/global/jquery-migrate/data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//
// https://jquery.com/upgrade-guide/3.0/#data

/* eslint-disable prefer-rest-params */
/* eslint-disable prefer-rest-params, func-names */
export default function () {
const oldData = jQuery.data;
jQuery.data = function (elem, name, value) {
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/global/jquery-migrate/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//
// https://jquery.com/upgrade-guide/3.0/#breaking-change-deprecated-context-and-selector-properties-removed

/* eslint-disable prefer-rest-params */
/* eslint-disable prefer-rest-params, func-names */
export default function () {
const oldInit = jQuery.fn.init;

Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/global/jquery-migrate/traversing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//
// https://jquery.com/upgrade-guide/3.0/#breaking-change-deprecated-context-and-selector-properties-removed

/* eslint-disable prefer-rest-params */
/* eslint-disable prefer-rest-params, func-names */
export default function () {
const oldFnFind = jQuery.fn.find;

Expand Down