Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): STRF-5948 Cleanup and XSS fix on Cart page. #1434

Merged
merged 1 commit into from
Jan 28, 2019
Merged

fix(storefront): STRF-5948 Cleanup and XSS fix on Cart page. #1434

merged 1 commit into from
Jan 28, 2019

Conversation

Ubersmake
Copy link
Contributor

What?

Certain product options allow for user-submitted input, which in the case of JS can be executed on the Cart page. This value is now escaped properly on the Cart page. This is also addressed on the Returns page.

This also cleans up code related to Configurable Fields, which were removed in #1407.

This does not address Custom Fields, which are entirely determined by the merchant.

Tickets / Documentation

@bigbot
Copy link

bigbot commented Jan 25, 2019

Autotagging @bigcommerce/storefront-team @davidchin

@bc-vandana
Copy link
Contributor

LGTM 👍

@Ubersmake Ubersmake merged commit fde8ad0 into bigcommerce:master Jan 28, 2019
@Ubersmake Ubersmake deleted the STRF-5948 branch January 28, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants