-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Amazon Pay and Google Pay to payment icons in footer #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
previously approved these changes
Jul 19, 2019
bookernath
reviewed
Jul 19, 2019
bookernath
reviewed
Jul 19, 2019
Fixed issue that prevented the Google Pay icon from displaying if it was the only payment icon selected in theme customization.
@AlbertJBurton oops, it looks like schema.json is minified now - would you mind fixing that? |
This looks good now. Thanks for your contribution! |
bookernath
approved these changes
Jul 19, 2019
Adding the Apple Pay Logo to the payment types would also be beneficial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Merchants should have the ability to advertise acceptance of payments via alternate means other than credit cards or PayPal. Two popular payment methods available through BigCommerce are Amazon Pay and Google Pay. This change adds the icons for these payment methods and allows customization of the theme to display these icons in the footer if desired.
Tickets / Documentation
N/A
Screenshots (if appropriate)
New Amazon Pay and Google Pay icons with existing payment icons
New options in the Header & Footer customization menu