Put nanobar back #1553
Merged
Put nanobar back #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bookernath
commented
Jul 26, 2019
| // ============================================================================= | ||
|
|
||
| .nanobar { | ||
| display: none; |
There was a problem hiding this comment.
this is a straight revert except for this change to hide the bar.
bookernath
force-pushed
the
add-back-nanobar
branch
from
2d316e2
to
7e27499
Compare
junedkazi
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add back nanobar because we rely on it for tests.
But hide it with CSS to still get the perceptual benefit we were going for in #1537
We can fully remove nanobar later.
ping @bc-sandeep