Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-139 Unnecessary heading tag in carousel #1780

Merged
merged 2 commits into from
Aug 26, 2020
Merged

fix(storefront): BCTHEME-139 Unnecessary heading tag in carousel #1780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99ffff9
fix(storefront): BCTHEME-139 Unnecessary heading tag in carousel
BC-tymurbiedukhin Aug 12, 2020
9871390
Merge branch 'master' into BCTHEME-139
BC-tymurbiedukhin Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Changelog

## Draft
Selected state on search page not announced. [#1788](https://github.com/bigcommerce/cornerstone/pull/1788)
- Changed heading tag for carousel slides. [#1780](https://github.com/bigcommerce/cornerstone/pull/1780)
- Selected state on search page not announced. [#1788](https://github.com/bigcommerce/cornerstone/pull/1788)
- Added additional focusable element for rating announcing. [#1769](https://github.com/bigcommerce/cornerstone/pull/1769)
- Error messages from Write a Review should be announced. [#1777](https://github.com/bigcommerce/cornerstone/pull/1777)
- Fixed issue with missing logo on mobile and tablet. [#1767](https://github.com/bigcommerce/cornerstone/pull/1767)
Expand All @@ -16,6 +17,7 @@ Selected state on search page not announced. [#1788](https://github.com/bigcomme
- Added modal trap for for product details. [#1758](https://github.com/bigcommerce/cornerstone/pull/1758)
- Added tooltips for carousel Previous and Next buttons. [#1749](https://github.com/bigcommerce/cornerstone/pull/1749)


## 4.9.0 (07-28-2020)
- Added correct alt text on image change in product view. [#1747](https://github.com/bigcommerce/cornerstone/pull/1747)
- Description tab is hidden in case of empty product descrioption. [#1746](https://github.com/bigcommerce/cornerstone/pull/1746)
Expand Down
2 changes: 1 addition & 1 deletion templates/components/carousel-content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="heroCarousel-content{{#unless show_background}} heroCarousel-content--empty{{/unless}}">
<h1 class="heroCarousel-title">{{{heading}}}</h1>
<span class="heroCarousel-title">{{{heading}}}</span>
<p class="heroCarousel-description">{{{text}}}</p>
{{#if button_text}}
<span class="heroCarousel-action button button--primary button--large">{{button_text}}</span>
Expand Down