Hide social sharing icons from quick view #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/themes-team |
bookernath
force-pushed
the
social-icons
branch
from
56501f4
to
4cd3bd4
Compare
junedkazi
approved these changes
Nov 5, 2020
BC-tymurbiedukhin
previously approved these changes
Nov 5, 2020
bookernath
force-pushed
the
social-icons
branch
from
4cd3bd4
to
08a0991
Compare
|
Merging after discussion with @bc-as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Instead of adding global JS to make sure social icons load, we will instead hide them from quick view. Making this change as the previous approach introduced a performance regression.
Screenshots (if appropriate)
Normal PDP:
Quick view:
Depends on
stencil-utilsrelease and https://github.com/bigcommerce/bigcommerce/pull/38045