Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): ES-2138 fixed count showing issue for category facet #2035

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

bc-krishsenthilraj
Copy link
Contributor

@bc-krishsenthilraj bc-krishsenthilraj commented Apr 9, 2021

What?

Category facet does not show product count next to it when the count is 0.

Why?

In theme file we have a check to show product count for Category facet only if it is greater than 0. Since, for our use case the count is 0, it's not shown. So, I have removed the if block to show the count always. For all other facets we show the count always. Only for Category it is different. To keep consistency across all facets this fix is made.

Tickets / Documentation

Screenshots (if appropriate)

Note: Please use the theme file (Cornerstone-5.3.0_ES-2138_Fix.zip) uploaded to ES-2138.

Steps:
Login to CP
Navigate to Storefront -> My Themes, upload the theme file & apply it
Follow the steps provided in the ticket
Observe that product count is shown next to Category facet

After Fix:
image

Before Fix:
image

@bigbot
Copy link

bigbot commented Apr 9, 2021

Autotagging @bigcommerce/themes-team

@bc-alexsaiannyi
Copy link
Contributor

@bc-krishsenthilraj looks fine to me. Just add please a record to changelog.

@bc-aodvak
Copy link

Screen Shot 2021-04-09 at 11 46 33 AM

💚

@bc-dhuynh bc-dhuynh merged commit 5155277 into bigcommerce:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants