Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-990 Product image not shown in Pinterest preview if not signed in #2203

Merged
merged 2 commits into from
May 3, 2022
Merged

fix(storefront): BCTHEME-990 Product image not shown in Pinterest preview if not signed in #2203

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e1fd0e
fix(storefront): BCTHEME-990 Product image not shown in Pinterest pre…
bc-vlad-dlogush Apr 21, 2022
b81d031
Merge branch 'master' into BCTHEME-990
bc-vlad-dlogush May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Product image not shown in Pinterest preview if not signed in.[#2203](https://github.com/bigcommerce/cornerstone/issues/2203)
- Remove translations for adminBar component [#2196](https://github.com/bigcommerce/cornerstone/issues/2196)
- Remove adminBar. [#2191](https://github.com/bigcommerce/cornerstone/issues/2191)
- When price list price is set for currency, the cart does not respect product's price.[#2190](https://github.com/bigcommerce/cornerstone/issues/2190)
Expand Down
2 changes: 1 addition & 1 deletion templates/components/common/share.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
{{else if service '===' 'pinterest'}}
<a class="socialLinks__link icon icon--{{service}}"
title="{{{capitalize service}}}"
href="https://pinterest.com/pin/create/button/?url={{getVar 'encodedUrl'}}&amp;description={{getVar 'encodedTitle'}}"
href="https://pinterest.com/pin/create/button/?url={{getVar 'encodedUrl'}}&amp;media={{getImageSrcset ../product.main_image (cdn ../theme_settings.default_image_product) 1x=../theme_settings.zoom_size}}&amp;description={{getVar 'encodedTitle'}}"
target="_blank"
rel="noopener"
{{{annotation}}}
Expand Down