Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-1985 Fix stored XSS within company address field #2485

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix(storefront): BCTHEME-1985 Fix stored XSS within company address field #2485

merged 2 commits into from
Oct 1, 2024

Conversation

bc-donfran
Copy link
Contributor

@bc-donfran bc-donfran commented Sep 24, 2024 •
edited by jira bot
Loading

What?

In the address-list.html field, the the company field should be {{}} rather than {{{}}} to prevent an XSS attack

Tickets/Documentation

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Screenshots

Before:
image

After:
image

@bc-azvierieva bc-azvierieva requested a review from a team September 24, 2024 12:25
@bc-donfran bc-donfran merged commit f9f00f8 into master Oct 1, 2024
2 of 3 checks passed
@bc-donfran bc-donfran deleted the BCTHEME-1985 branch October 1, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhmatt mjhmatt mjhmatt approved these changes

@BC-krasnoshapka BC-krasnoshapka BC-krasnoshapka approved these changes

@adamdyche adamdyche Awaiting requested review from adamdyche

@bc-vlad-dlogush bc-vlad-dlogush Awaiting requested review from bc-vlad-dlogush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bc-donfran @mjhmatt @BC-krasnoshapka