Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STENCIL-2457 - fix incorrect suggestion warning #934

Merged
merged 1 commit into from
Feb 20, 2017
Merged

STENCIL-2457 - fix incorrect suggestion warning #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Add a larger view of a swatch image when option is hovered over on the product page [#923](https://github.com/bigcommerce/stencil/pull/923)
- Fixes an issue with file upload button not properly displaying in IE [#925](https://github.com/bigcommerce/stencil/pull/925)
- Make sure product review email links automatically pop the review form [#928](https://github.com/bigcommerce/stencil/pull/928)
- Fixes an issue where search results would incorrectly state there were no results when there were results visible [#934](https://github.com/bigcommerce/stencil/pull/934)

## 1.5.2 (2017-02-14)
- Added a setting to theme editor schema to show/hide the homepage carousel [#909](https://github.com/bigcommerce/stencil/pull/909)
Expand Down
16 changes: 9 additions & 7 deletions templates/pages/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,15 @@
<a href="{{forms.search.suggested_query.url}}" class="search-refine">{{lang 'forms.search.refine'}}</a>
</div>

<div class="search-suggestion">
<p>
{{lang 'forms.search.your_search_for'}}
"<strong>{{forms.search.query}}</strong>"
{{lang 'forms.search.no_match'}}
</p>
</div>
{{#if result_count '===' 0}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just use unless here ?

<div class="search-suggestion">
<p>
{{lang 'forms.search.your_search_for'}}
"<strong>{{forms.search.query}}</strong>"
{{lang 'forms.search.no_match'}}
</p>
</div>
{{/if}}
{{/if}}

{{#if category_results.length}}
Expand Down