Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STENCIL-2445: Remove unused variable causing js error #938

Merged
merged 1 commit into from
Feb 21, 2017
Merged

STENCIL-2445: Remove unused variable causing js error #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
- Fix an issue with special characters in carousel text [#932](https://github.com/bigcommerce/stencil/pull/932)
- Remove an unnecessary and confusing option in theme editor [#927](https://github.com/bigcommerce/stencil/pull/927)
- Fix an issue where required product list options would display an invalid "none" choice [#929](https://github.com/bigcommerce/stencil/pull/929)

- Remove unused variable causing js error with search in the nav [#938](https://github.com/bigcommerce/stencil/pull/938)

## 1.5.2 (2017-02-14)
- Added a setting to theme editor schema to show/hide the homepage carousel [#909](https://github.com/bigcommerce/stencil/pull/909)
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/global/stencil-dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default class StencilDropdown {

// callback "hide"
if (this.extendables && this.extendables.hide) {
this.extendables.hide(event);
this.extendables.hide();
}

$dropDown.removeClass('is-open f-open-dropdown').attr('aria-hidden', 'true');
Expand Down