Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STENCIL-3328 - Remove footer scripts from amp-iframe #983

Merged
merged 1 commit into from
Mar 27, 2017
Merged

STENCIL-3328 - Remove footer scripts from amp-iframe #983

merged 1 commit into from
Mar 27, 2017

Conversation

bookernath
Copy link
Contributor

Removing the footer.scripts helper from the amp-iframe so footer
scripts will NOT render in the amp product options iframe. This was
causing weird display of product options on some stores.

Ping @junedkazi

Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just confirm this change fixes the issue by removing it from the store iframe using edit theme files.

Removing the footer.scripts helper from the amp-iframe so footer
scripts will NOT render in the amp product options iframe. This was
causing weird display of product options on some stores.
@bookernath
Copy link
Contributor Author

Tested on my store with a JS alert. Confirmed it works as intended.

@junedkazi junedkazi merged commit 1d12917 into bigcommerce:master Mar 27, 2017
@bookernath bookernath deleted the footer-scripts-amp-iframe branch March 27, 2017 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants