Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STENCIL-3352 - Fix product quick view 'Write a Review' link #995

Merged
merged 1 commit into from
Apr 11, 2017
Merged

STENCIL-3352 - Fix product quick view 'Write a Review' link #995

merged 1 commit into from
Apr 11, 2017

Conversation

mjschock
Copy link
Contributor

@mjschock mjschock commented Apr 11, 2017

What?

Fixes a bug pointed out by @ocvninfo where clicking the 'Write a Review' link in the quick view would take you to the product page but would not open the modal.

Tickets / Documentation

Add links to any relevant tickets and documentation.

GIF with Fix

http://recordit.co/CS8jVePxfd/gif/notify

@bigcommerce/stencil-team

Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChangeLog entry please.

CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fix product quick view 'Write a Review' link [#995](https://jira.bigcommerce.com/browse/STENCIL-3352)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you go @junedkazi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url should point to the PR not the jira ticket :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no idea what you're talking about :)

@mjschock mjschock merged commit 2b1f849 into bigcommerce:master Apr 11, 2017
@mjschock mjschock deleted the STENCIL-3352 branch April 11, 2017 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants