Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add data analysis for MOOCCubeX #89

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

ustcchx
Copy link

@ustcchx ustcchx commented May 3, 2023

Thanks for sending a pull request!
Please make sure you click the link above to view the contribution guidelines,
then fill out the blanks below.

Description

  • Add data analysis for MOOCCubeX
  • Add the URL of MOOCCubeX dataset to README.md
  • Add Hongxu Chen to AUTHOR.md

What does this implement/fix? Explain your changes.

  • Add data analysis for MOOCCubeX
  • Add the URL of MOOCCubeX dataset to README.md
  • Add Hongxu Chen to AUTHOR.md

Pull request type

  • [DATASET] Add a new dataset
  • [BUGFIX] Bugfix
  • [FEATURE] New feature (non-breaking change which adds functionality)
  • [BREAKING] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [STYLE] Code style update (formatting, renaming)
  • [REFACTOR] Refactoring (no functional changes, no api changes)
  • [BUILD] Build related changes
  • [DOC] Documentation content changes
  • [OTHER] Other (please describe):

Changes

  • Add data analysis document
  • Add the URL of MOOCCubeX dataset to README.md
  • Add Hongxu Chen to AUTHOR.md

Does this close any currently open issues?

NO

Any relevant logs, error output, etc?

NO

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [FEATURE], [BREAKING], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage and al tests passing
  • Code is well-documented (extended the README / documentation, if necessary)
  • If this PR is your first one, add your name and github account to AUTHORS.md

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link

@fannazya fannazya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the URL of the dataset into "https://github.com/THU-KEG/MOOCCubeX" and specify the data file in MOOCCubeX.ipynb.

Copy link

@fannazya fannazya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@tswsxk
Copy link

tswsxk commented May 6, 2023

Synchronize with the master branch so that the automatic test could be run. In addition, the title of this PR should contain the pull request type @fannazya

@ustcchx ustcchx closed this May 6, 2023
@ustcchx ustcchx reopened this May 6, 2023
@ustcchx ustcchx closed this May 6, 2023
@ustcchx ustcchx reopened this May 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (da9415a) 91.26% compared to head (3741237) 91.26%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files           6        6           
  Lines         126      126           
=======================================
  Hits          115      115           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not allow attached figures,please make sure all results generated by the code without any reference.

@ustcchx
Copy link
Author

ustcchx commented May 8, 2023

I have changed the form of figures' presentation. All the figures are generated by code now. @fannazya

@ustcchx ustcchx changed the title Add data analysis for MOOCCubeX and add the URL of MOOCCubeX dataset to README.md [DOC] Add data analysis for MOOCCubeX and add the URL of MOOCCubeX dataset to README.md May 9, 2023
@ustcchx ustcchx changed the title [DOC] Add data analysis for MOOCCubeX and add the URL of MOOCCubeX dataset to README.md [DOC] Add data analysis for MOOCCubeX, add the URL of MOOCCubeX dataset to README.md and add Hongxu Chen to AUTHOR.md May 9, 2023
@ustcchx ustcchx closed this May 9, 2023
@ustcchx ustcchx reopened this May 9, 2023
@tswsxk tswsxk changed the title [DOC] Add data analysis for MOOCCubeX, add the URL of MOOCCubeX dataset to README.md and add Hongxu Chen to AUTHOR.md [DOC] Add data analysis for MOOCCubeX May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants