refactor: 🔥 Moved constants name into constant file

binary-com · Aug 28, 2024 · d0cf5a8 · d0cf5a8
1 parent f455623
commit d0cf5a8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/packages/bot-web-ui/src/pages/server-side-bot/add-bot/constants.ts b/packages/bot-web-ui/src/pages/server-side-bot/add-bot/constants.ts
@@ -1 +1,2 @@
 export const SERVER_BOT_FIELDS = 'server-form-fields';
+export const SERVER_BOT_LOSS_THRESHOLD_WARNING = 'server-bot-loss-threshold-warning';
diff --git a/packages/bot-web-ui/src/pages/server-side-bot/add-bot/form-wrappers/useQsSubmitHandler.tsx b/packages/bot-web-ui/src/pages/server-side-bot/add-bot/form-wrappers/useQsSubmitHandler.tsx
@@ -2,6 +2,7 @@ import { useFormikContext } from 'formik';
 import { useStore } from '@deriv/stores';
 import { useDBotStore } from 'Stores/useDBotStore';
 import { rudderStackSendQsRunStrategyEvent } from '../../../../analytics/rudderstack-quick-strategy';
+import { SERVER_BOT_LOSS_THRESHOLD_WARNING } from '../constants';
 import { TFormValues } from '../types';
 
 const useQsSubmitHandler = () => {
@@ -20,7 +21,7 @@ const useQsSubmitHandler = () => {
     const handleSubmit = async () => {
         const loss_amount = Number(values?.loss ?? 0);
         const profit_threshold = Number(values?.profit ?? 0);
-        const stored_dont_show_warning_value = localStorage?.getItem('SERVER_BOT_LOSS_THRESHOLD_WARNING');
+        const stored_dont_show_warning_value = localStorage?.getItem(SERVER_BOT_LOSS_THRESHOLD_WARNING);
         const dont_show_warning = JSON.parse(stored_dont_show_warning_value ?? 'false');
         if (
             !loss_threshold_warning_data.already_shown &&

diff --git a/...-web-ui/src/pages/server-side-bot/add-bot/parts/__tests__/loss-threshold-warning.spec.tsx b/...-web-ui/src/pages/server-side-bot/add-bot/parts/__tests__/loss-threshold-warning.spec.tsx
@@ -6,6 +6,7 @@ import userEvent from '@testing-library/user-event';
 import { mock_ws } from 'Utils/mock';
 import RootStore from 'Stores/root-store';
 import { DBotStoreProvider, mockDBotStore } from 'Stores/useDBotStore';
+import { SERVER_BOT_LOSS_THRESHOLD_WARNING } from '../../constants';
 import LossThresholdWarningDialog from '../loss-threshold-warning-dialog';
 
 jest.mock('@deriv/bot-skeleton/src/scratch/blockly', () => jest.fn());
@@ -88,6 +89,6 @@ describe('LossThresholdWarningDialog', () => {
         });
         const checkbox = screen.getByRole('checkbox', { name: /Do not show this message again./i });
         userEvent.click(checkbox);
-        expect(localStorage.getItem('SERVER_BOT_LOSS_THRESHOLD_WARNING')).toEqual('true');
+        expect(localStorage.getItem(SERVER_BOT_LOSS_THRESHOLD_WARNING)).toEqual('true');
     });
 });
diff --git a/...ages/bot-web-ui/src/pages/server-side-bot/add-bot/parts/loss-threshold-warning-dialog.tsx b/...ages/bot-web-ui/src/pages/server-side-bot/add-bot/parts/loss-threshold-warning-dialog.tsx
@@ -3,6 +3,7 @@ import { Checkbox, Dialog } from '@deriv/components';
 import { observer } from '@deriv/stores';
 import { Localize, localize } from '@deriv/translations';
 import { useDBotStore } from 'Stores/useDBotStore';
+import { SERVER_BOT_LOSS_THRESHOLD_WARNING } from '../constants';
 import useQsSubmitHandler from '../form-wrappers/useQsSubmitHandler';
 import './loss-threshold-warning-dialog.scss';
 
@@ -27,9 +28,9 @@ const LossThresholdWarningDialog = observer(() => {
     };
 
     const handleDontShowAgain = () => {
-        const stored_dont_show_warning_value = localStorage?.getItem('SERVER_BOT_LOSS_THRESHOLD_WARNING');
+        const stored_dont_show_warning_value = localStorage?.getItem(SERVER_BOT_LOSS_THRESHOLD_WARNING);
         const dont_show_warning = JSON.parse(stored_dont_show_warning_value ?? 'false');
-        localStorage.setItem('SERVER_BOT_LOSS_THRESHOLD_WARNING', `${!dont_show_warning}`);
+        localStorage.setItem(SERVER_BOT_LOSS_THRESHOLD_WARNING, `${!dont_show_warning}`);
     };
 
     return (