Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P2PS] refactor: p2p modals #10193

Merged
merged 354 commits into from
Nov 27, 2023
Merged

[P2PS] refactor: p2p modals #10193

merged 354 commits into from
Nov 27, 2023

Conversation

farrah-deriv
Copy link
Contributor

@farrah-deriv farrah-deriv commented Sep 20, 2023 •
edited
Loading

Changes:

This is the feature branch for refactoring the modals in p2p package. Migrating to TypeScript and unit tests are added.
Each commit is associated with PR which has been already reviewed and merged.

Screenshots:

Please provide some screenshots of the change.

farrah-deriv and others added 30 commits June 5, 2023 09:15
@farrah-deriv
Merge pull request #7 from farhan-nurzi-deriv/P2PS-728/refactor-recom…
a4cccef 
…mendedby-component

FarhanNurzi/P2PS-728/Refactor RecommendedBy
@github-actions @DerivFE @farrah-deriv
translations: 📚 sync translations with crowdin (binary-com#8881)
0ae461a 
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
@thisyahlen-deriv @farrah-deriv
thisyahlen/fix: change algo for realAccountSignup (binary-com#8656)
02fdaa8 
* fix: change algo for realAccountSignup

* fix: refactor

* redeploy: vercel
@github-actions @DerivFE @farrah-deriv
translations: 📚 sync translations with crowdin (binary-com#8885)
bf596c6 
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
@github-actions @DerivFE @farrah-deriv
translations: 📚 sync translations with crowdin (binary-com#8890)
4bd5eae 
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
@likhith-deriv @farrah-deriv
likhith/fix: 🐛 resolved required field error (binary-com#8886)
9385de8 
* fix: 🐛 resolved required field error

* feat: fixed issue with Citizen field
@farrah-deriv
Merge remote-tracking branch 'upstream/master' into p2p-refactor
ab569d6
@farrah-deriv
Merge pull request #18 from ameerul-deriv/refactor-recommend-user
09b10fe 
Refactor Recommend User
@farrah-deriv
Merge pull request #15 from ameerul-deriv/refactor-floating-rate
6f6ad4c 
Refactor Floating Rate
@nada-deriv
refactor: removed unused code
0355c03
@nada-deriv
refactor: updated test
fc7f880
@farrah-deriv
Merge pull request #19 from nada-deriv/nada/P2PS-734/verification-ref…
93b7efa 
…actor

Verification component refactor
@farrah-deriv
fix: code smells
227ddef
@farrah-deriv
Merge pull request #17 from nada-deriv/nada/P2PS-820/online-status-re…
979d8ce 
…factor

refactor: online status component refactoring
@farrah-deriv
Merge pull request #20 from farrah-deriv/fix-code-smells
10637c9 
fix: code smells
@farrah-deriv
fix: tests
1ef746e
@nada-deriv
refactor: reduce code complexity to remove code smell
52194e9
@nada-deriv
refactor: updated return
be89e7a
@nada-deriv
refactor: udpated test
dc04bef
@farrah-deriv
Merge remote-tracking branch 'upstream/master' into p2p-refactor
70ccac0
@farrah-deriv
Merge pull request #21 from nada-deriv/code-smell
ca36b7b 
refactor: reduce code complexity to remove code smell
@farrah-deriv
Merge remote-tracking branch 'upstream/master' into p2p-refactor
5fb65f5
@farrah-deriv
Merge branch 'master' into p2p-refactor
8d83b4f
@Farhan-slurrp
refactor: delete text component and use default button text styles in…
dc0e2dc 
…stead
@farrah-deriv
Merge pull request #23 from farhan-nurzi-deriv/p2p-refactor
1cca12a 
refactor: delete text component and use default button text styles in…
@farrah-deriv
Merge remote-tracking branch 'upstream/master' into p2p-refactor
d2307e6
@farrah-deriv
Merge remote-tracking branch 'upstream/master' into p2p-refactor
8781e14
@farrah-deriv
Merge remote-tracking branch 'upstream/master' into p2p-refactor
1dc14bd
@farrah-deriv
Merge remote-tracking branch 'upstream/master' into p2p-refactor
65cfd8f
@farrah-deriv
Merge remote-tracking branch 'upstream/master' into p2p-refactor
93e9c5b
@farrah-deriv
Merge pull request #74 from ameerul-deriv/P2PS-1927-unabled-to-place-…
e5149e5 
…buy-sell-order

[P2PS] Ameerul /P2PS-1927 Unable to place buy/sell order from the advertiser page both in web and responsive view
@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

@github-actions GitHub Actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@farrah-deriv
Merge pull request #76 from ameerul-deriv/P2PS-1994-wrong-title-for-b…
25b5538 
…uy/sell-modal-issue

[P2PS] Ameerul /P2PS-1994 Wrong title for buy/sell modal from advertiser page
@github-actions GitHub Actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

@github-actions GitHub Actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 46 Code Smells

No Coverage information No Coverage information
6.1% 6.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@github-actions GitHub Actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@farrah-deriv farrah-deriv merged commit 32aeb33 into binary-com:master Nov 27, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niloofar-deriv niloofar-deriv niloofar-deriv approved these changes

@ameerul-deriv ameerul-deriv ameerul-deriv approved these changes

@nada-deriv nada-deriv nada-deriv approved these changes

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

Assignees
No one assigned
Labels
Components P2P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.