Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH] Sergei / TRAH-2591 / MT5 Trade Screen #12793

Merged

Conversation

sergei-deriv
Copy link
Contributor

@sergei-deriv sergei-deriv commented Jan 7, 2024

Changes:

Add Trade modal for CFD accounts

Created:

  • TradeModal component
  • MT5TradeScreen component

Modified:

  • Modal component
  • ModalProvider
  • Clipboard component
  • MT5TradeDetailsItem component
  • MT5TradeLink component
  • MT5TradeDetailsItem component
  • AddedCTraderAccountsList component
  • AddedMT5AccountsList component
  • AddedDxtradeAccountsList component

Card:

https://app.clickup.com/t/20696747/TRAH-2591

Screenshots:

Screenshot 2024-01-08 at 00 53 02 Screenshot 2024-01-08 at 01 16 46 Screenshot 2024-01-08 at 01 16 31

Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 10, 2024 9:35am

Copy link
Contributor

github-actions bot commented Jan 7, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12793](https://github.com/binary-com/deriv-app/pull/12793)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-trah-2591mt5-trad-92b0be.binary.sx?qa_server=red.derivws.com&app_id=32692
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-trah-2591mt5-trad-92b0be.binary.sx
- **App ID**: `32692`

@coveralls
Copy link

coveralls commented Jan 7, 2024

Coverage Status

coverage: 34.537% (-0.2%) from 34.713%
when pulling b394d7f on sergei-deriv:sergei/trah-2591/mt5-trade-screen
into a2ffb37 on binary-com:master.

Copy link
Contributor

github-actions bot commented Jan 7, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-trah-2591mt5-trad-92b0be.binary.sx/

Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Jan 9, 2024
aizad-deriv
aizad-deriv previously approved these changes Jan 10, 2024
Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
3.8% Duplication on New Code

See analysis details on SonarCloud

@mahdiyeh-deriv mahdiyeh-deriv merged commit 8820630 into binary-com:master Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants