Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check slow build #5469

Merged

Conversation

balakrishna-deriv
Copy link
Contributor

@balakrishna-deriv balakrishna-deriv commented May 17, 2022

Changes:

Github references causing build to slow down - npm/cli#4896

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented May 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview May 18, 2022 at 6:27AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5469](https://github.com/binary-com/deriv-app/pull/5469)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-balakrishna-binary-check-slow-build.binary.sx?qa_server=frontend.binaryws.com&app_id=31481
    - **Original**: https://deriv-app-git-fork-balakrishna-binary-check-slow-build.binary.sx
- **App ID**: `31481`

yashim-deriv
yashim-deriv previously approved these changes May 18, 2022
Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

matin-deriv
matin-deriv previously approved these changes May 18, 2022
Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove no_output_timeout

@codecov-commenter
Copy link

Codecov Report

Merging #5469 (4dfd8dc) into master (a060821) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5469   +/-   ##
=======================================
  Coverage   18.33%   18.33%           
=======================================
  Files        1286     1286           
  Lines       29179    29179           
  Branches     4926     4926           
=======================================
  Hits         5349     5349           
  Misses      23549    23549           
  Partials      281      281           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a060821...4dfd8dc. Read the comment docs.

yashim-deriv
yashim-deriv previously approved these changes May 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

@balakrishna-deriv balakrishna-deriv merged commit eac97da into binary-com:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants