Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sergei / wall 272 / wallet desktop header #8334
Sergei / wall 272 / wallet desktop header #8334
Changes from 22 commits
f7d0253
d39c6af
c710fed
24acfc1
4f430db
7605b06
faf60d4
09901d1
a71c3be
3032433
8099741
97a807c
8c18a2e
2eb4110
6af236a
d9070f4
5d48673
7e97347
6abe031
7c42f21
a47e9b5
2ffedf1
97a66b4
c62ca2e
f24a763
a8ab781
25bdf4d
b39cf77
ddd6063
6c100d1
951bf82
19091ce
046fd81
4dcb497
e8ad016
f170a1b
d29c931
12dc9b6
efecdfe
9d4c467
4b5dbdd
7749512
8ab92a2
f245fa0
09d1ad4
db1c60a
1b0c45c
4a81b4a
74d1d4c
8fff425
b600f72
245b307
461dc7a
95a873a
a0869fd
061f046
f79b5ca
62439b2
72e8d8c
b26e655
5c350cd
7b85b32
6007b52
0f4dd84
929e65a
285e58e
13328ef
abad18a
1a5a629
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergei-deriv could you check, maybe we can use
current_currency_type
from client store?const is_fiat = current_currency_type === 'fiat'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heorhi-deriv
current_currency_type
is for current account, but one account can has many wallets and I have to check wallet currency. I tried to check currency type from client store (website_status.currencies_config) like this:const is_fiat = !isCryptocurrency(currency)
but there is no USDT currency from BE, just UST and in result I have case when USDT is fiat. At this moment I decided to add check for 'USDT' too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergei-deriv although this is a working variant to render the text:
I suggest you to use the next variant:
for me it has few benefits:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergei-deriv same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergei-deriv can use type from
packages/appstore/src/types/common.types.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @sergei-deriv using variables in Localize is not allowed. please check this link (https://deriv-group.slack.com/archives/C3AHMSM3P/p1677553396124379)
again i recommend you to use
<Text>{localize(string)}</Text>
pattern or
<Text> <Localize i18n_default_text='string' /> </Text>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergei-deriv size='xs'