-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: renamed your ads are running to hide my ads #8576
fix: renamed your ads are running to hide my ads #8576
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
Codecov Report
@@ Coverage Diff @@
## master #8576 +/- ##
===========================================
+ Coverage 0.05% 20.06% +20.00%
===========================================
Files 117 1827 +1710
Lines 3425 41469 +38044
Branches 893 8243 +7350
===========================================
+ Hits 2 8319 +8317
- Misses 3423 32288 +28865
- Partials 0 862 +862
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-609ads-are-runni-455f99.binary.sx/ |
931f10c
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | e34e31b | packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx | View secret |
- | Generic High Entropy Secret | e34e31b | packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
931f10c
to
582ff90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
<Text color='profit-success' line_height='m' size='xxs'> | ||
<Text | ||
color={is_advert_listed ? 'profit-success' : 'less-prominent'} | ||
line_height='m' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can remove this line cause the default for line_height is m 👍 same with the others
line_height='m' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. there are other issues as well i found with this file. will do it as part of refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . But any idea why the deployment is failed?
the deployment failed due to the node issue. haven't updated it. |
👌 Pull request has been updated with the base branch by Paimon the Release Bot |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
✨ PR has been merged by Paimon the Release Bot |
Changes:
Renamed your ads are running to hide my ads.
Screenshots:
Please provide some screenshots of the change.