Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ameerul /P2PS-828 refactor my profile page #8943

Conversation

ameerul-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the P2P label Jun 8, 2023
@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 3:54am

…-separator-container

P2PS-901 refactor my profile separator container
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8943](https://github.com/binary-com/deriv-app/pull/8943)
- **URLs**:
    - **w/ App ID + Server**: https://vercel.live/open-feedback/deriv-app-git-fork-ameerul-deriv-p2ps-828-refactor-my-pr-cad68c.binary.sx?qa_server=red.binaryws.com&app_id=23880
    - **Original**: https://vercel.live/open-feedback/deriv-app-git-fork-ameerul-deriv-p2ps-828-refactor-my-pr-cad68c.binary.sx
- **App ID**: `23880`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-828-refactor-my-pr-cad68c.binary.sx/

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #8943 (14f7e56) into master (d5c38a0) will not change coverage.
The diff coverage is n/a.

❗ Current head 14f7e56 differs from pull request most recent head 23576f4. Consider uploading reports for the commit 23576f4 to get more accurate results

@@          Coverage Diff           @@
##           master   #8943   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files         117     117           
  Lines        3425    3425           
  Branches      893     893           
======================================
  Hits            2       2           
  Misses       3423    3423           

ameerul-deriv and others added 3 commits June 9, 2023 10:26
…_/my-profile-form.spec.tsx

Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com>
…_/my-profile-form.spec.tsx

Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Generating Lighthouse report...

@ameerul-deriv ameerul-deriv force-pushed the P2PS-828-refactor-my-profile-page branch from 53c11ec to 23576f4 Compare July 12, 2023 02:23
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ameerul-deriv ameerul-deriv deleted the P2PS-828-refactor-my-profile-page branch October 12, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant